[PATCH] D121353: [SLP][NFC] This adds a test for a follow-up patch that fixes a look-ahead operand reordering issue

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 23:33:39 PST 2022


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment/question



================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/lookahead.ll:648
+; 2-wide splat loads in x86 use a single instruction so they are quite cheap.
+define weak_odr double @splat_loads(double *%array1, double *%array2, double *%ptrA, double *%ptrB) #0 {
+; CHECK-LABEL: @splat_loads(
----------------
do we need the weak_odr attribute?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121353/new/

https://reviews.llvm.org/D121353



More information about the llvm-commits mailing list