[PATCH] D121336: [BOLT][NFC] Check errors from Obj.dynamicEntries
Amir Ayupov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 9 20:25:03 PST 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd16bbc5340a4: [BOLT][NFC] Check errors from Obj.dynamicEntries (authored by Amir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121336/new/
https://reviews.llvm.org/D121336
Files:
bolt/lib/Rewrite/RewriteInstance.cpp
Index: bolt/lib/Rewrite/RewriteInstance.cpp
===================================================================
--- bolt/lib/Rewrite/RewriteInstance.cpp
+++ bolt/lib/Rewrite/RewriteInstance.cpp
@@ -5135,8 +5135,10 @@
"dynamic section sizes should match");
// Go through all dynamic entries to locate entries of interest.
- typename ELFT::DynRange DynamicEntries =
- cantFail(Obj.dynamicEntries(), "error accessing dynamic table");
+ auto DynamicEntriesOrErr = Obj.dynamicEntries();
+ if (!DynamicEntriesOrErr)
+ return DynamicEntriesOrErr.takeError();
+ typename ELFT::DynRange DynamicEntries = DynamicEntriesOrErr.get();
for (const Elf_Dyn &Dyn : DynamicEntries) {
switch (Dyn.d_tag) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121336.414268.patch
Type: text/x-patch
Size: 744 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220310/fef44f6e/attachment.bin>
More information about the llvm-commits
mailing list