[PATCH] D120523: [ValueTracking] Simplify llvm::isPointerOffset()

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Transforms/MemCpyOpt/opaque-ptr.ll:55
+  ret void
+}
+
----------------
nikic wrote:
> I think the main motivation for the additional code isn't scalable vectors, but rather cases that have a common non-constant index, like `GEP p, x, 0` and `GEP p, x, 1`.
yes you're right, I was trying to use `GEPOperator::collectOffset` here but it didn't handle vscale types and that was on my mind when writing the commit message


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120523/new/

https://reviews.llvm.org/D120523