[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 13:36:32 PST 2022


sunfish added a comment.

The overall approach here makes sense to me. The tests test/CodeGen/WebAssembly/global_dtors.ll and test/CodeGen/WebAssembly/lower-global-dtors.ll cover the main interesting corner cases that we've hit with this pass; they currently have wasm targets and wasm-specific CHECK lines, but could likely be ported to other targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121327/new/

https://reviews.llvm.org/D121327



More information about the llvm-commits mailing list