[PATCH] D121292: [VP] Add vp.fcmp comparison intrinsic and docs

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Need a Verifier.cpp check on the validity of the metadata

Equivalent for constrained intrinsics

  case Intrinsic::experimental_constrained_fcmp:                                 
  case Intrinsic::experimental_constrained_fcmps: {                              
    auto Pred = cast<ConstrainedFPCmpIntrinsic>(&FPI)->getPredicate();           
    Assert(CmpInst::isFPPredicate(Pred),                                         
           "invalid predicate for constrained FP comparison intrinsic", &FPI);   
    break;                                                                       
  }  



================
Comment at: llvm/docs/LangRef.rst:20153
+
+The '``llvm.vp.fcmp``' intrinsic returns a boolean value or vector of boolean
+values based on the comparison of its operands. The operation has a mask and an
----------------
Should only be a vector of boolean right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121292/new/

https://reviews.llvm.org/D121292