[PATCH] D120827: [VPlan] Helper to check if a recipe only uses scalar values of op.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1644
+
+  /// Returns true if the recipe only uses scalars of operand \p Op.
+  bool onlyScalarsUsed(const VPValue *Op) const override {
----------------
Ayal wrote:
> VPPredInstPHIRecipe has only PredInst as an operand, which is surely scalar.
Yes. Are you referring to the generic comment? 


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1779
+
+  /// Returns true if the recipe only uses scalars of operand \p Op.
+  bool onlyScalarsUsed(const VPValue *Op) const override {
----------------
Ayal wrote:
> Does VPExpandSCEVRecipe use only first lane?
It doesn't use any VPValue operands, so this can never be called without asserting. I remove it.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1927
+
+  /// Returns true if the recipe only uses scalars of operand \p Op.
+  bool onlyScalarsUsed(const VPValue *Op) const override {
----------------
Ayal wrote:
> VPScalarIVStepsRecipe uses only the first lane of its three operands?
Yes, I changed the code, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120827/new/

https://reviews.llvm.org/D120827