[PATCH] D121313: [IROutliner] Fix miscounting of exit paths when a single phi node used as an output for several outlined regions.
Andrew Litteken via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 9 11:21:02 PST 2022
AndrewLitteken added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:1120
+ // are trying to analyze, meaning, that if it was outlined, we would be
+ // adding an extra input. We ignore this case for now, and so ignore the
+ // region.
----------------
paquette wrote:
> > We ignore this case for now, and so ignore the region
>
> Should this be a TODO?
Yes, probably. I'll add a note before I push it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121313/new/
https://reviews.llvm.org/D121313
More information about the llvm-commits
mailing list