[PATCH] D121311: [IROutliner] Ignore Regions where part of an outlined phi nodes incoming block is included, but the final branch instruction is not

Andrew Litteken via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 10:56:32 PST 2022


AndrewLitteken created this revision.
Herald added subscribers: ormris, hiraditya.
Herald added a project: All.
AndrewLitteken requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Reproduced: https://godbolt.org/z/roznP99P3

When outlining a phi node, if the the incoming branch is a block contained in the region and the branch from that block is not outlined, we create broken code. The fix is to recognize when that branch from the included incoming block is not contained, and ignore the region.


https://reviews.llvm.org/D121311

Files:
  llvm/lib/Transforms/IPO/IROutliner.cpp
  llvm/test/Transforms/IROutliner/phi-nodes-parent-block-referential.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121311.414156.patch
Type: text/x-patch
Size: 5914 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220309/f8fd7d7a/attachment-0001.bin>


More information about the llvm-commits mailing list