[PATCH] D120993: [PassManager] Add pretty stack entries before P->run() call.

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 09:31:17 PST 2022


myhsu added a comment.

In D120993#3370129 <https://reviews.llvm.org/D120993#3370129>, @fhahn wrote:

> In D120993#3370083 <https://reviews.llvm.org/D120993#3370083>, @nikic wrote:
>
>> FYI it looks like this isn't as free as I would have expected: http://llvm-compile-time-tracker.com/compare.php?from=338dfcd60f843082bb589b287d890dbd9394eb82&to=128745cc2681c284bc6d0150a319673a6d6e8424&stat=instructions
>
> Yeah that's not great. I'll revert it in a bit and check if there's anything in particular that's very expensive.

My ballpark guess is that the whole SIGINFO printing feature is kinda expensive, since we're forced to load `GlobalSigInfoGenerationCounter` every time, but the feature is actually never used upstream.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120993/new/

https://reviews.llvm.org/D120993



More information about the llvm-commits mailing list