[PATCH] D120858: [NFC][XCOFF] Refactor and format XCOFFObjectWriter.cpp.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 08:22:44 PST 2022


DiggerLin added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:666
+                                         uint8_t NumberOfAuxEntries) {
+  writeSymbolName(SymbolName); // Magic, Offset, SymbolName
+  W.write<uint32_t>(Value);
----------------
 the writeSymbolName(SymbolName) can self explain . 
the comment  "Magic, Offset, SymbolName " description of functionality of the writeSymbolName(), if you want to put the comment, it maybe better to put before the  function   writeSymbolName definition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120858/new/

https://reviews.llvm.org/D120858



More information about the llvm-commits mailing list