[PATCH] D121276: [CMake] Include runtimes test suites in check-all

[Louis Dionne via Phabricator via llvm-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Interesting -- so you basically write the test dependencies, parameters and test suites i.e. everything that `check-runtimes` contains into a file:

  add_lit_target(check-runtimes
      "Running all regression tests"
      ${RUNTIMES_LIT_TESTSUITES}
      PARAMS ${RUNTIMES_LIT_PARAMS}
      DEPENDS ${RUNTIMES_LIT_DEPENDS}
      ARGS ${RUNTIMES_LIT_EXTRA_ARGS}
  )

and then you add that directly to `check-all` from the main build.

This makes a lot of sense in principle, I'm running some tests right now but this LGTM. I assume you've tested it too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121276/new/

https://reviews.llvm.org/D121276