[PATCH] D121182: Expose ScalarizerPass options to C++ (not just commandline)

Benoit Jacob via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 07:33:57 PST 2022


Benoit added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Scalarizer.cpp:194
+      : ParallelLoopAccessMDKind(ParallelLoopAccessMDKind), DT(DT),
+       ScalarizeVariableInsertExtract(options.ScalarizeVariableInsertExtract.getValueOr(ClScalarizeVariableInsertExtract)),
+       ScalarizeLoadStore(options.ScalarizeLoadStore.getValueOr(ClScalarizeLoadStore))   {}
----------------
bjope wrote:
> With the current patch you won't be able to override any pass options setup by the pass manager etc.
> I would expect that the cmd line value has higher precedence.
> 
Thanks, that makes sense. Code updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121182/new/

https://reviews.llvm.org/D121182



More information about the llvm-commits mailing list