[PATCH] D121229: [AMDGPU] Split FeatureAtomicFaddInsts feature. NFC.

Wed Mar 9 07:06:03 PST 2022

foad added a comment.

> Really all it is doing is:
>
> 1. Setting two predicates on an instruction, like HasAtomicFaddInsts and isGFX940Plus, instead of using compound predicates like HasAtomicFaddInstsGFX940. The hope here is to avoid an N^2 explosion of named predicates.
> 2. Using HasAtomicFaddNoRtnInsts instead of isGFX90APlus in a couple of places where it makes things more symmetrical.
>
> I could even split this into two separate patches.

D121289 <https://reviews.llvm.org/D121289> is a simpler patch that just does #1. Hopefully this avoids the concern about changing feature names.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121229/new/

https://reviews.llvm.org/D121229