[PATCH] D120825: [mlir][OpenMP] Generating enums in accordance with the guidelines

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Please add a pointer to the the llvm guidelines recommending this change.

Does OpenACC use any of this infra currently?



================
Comment at: llvm/unittests/Frontend/OpenMPParsingTest.cpp:76
 
   // FIXME: Why are these not lower case?
+  EXPECT_EQ(getScheduleKind("static"), OMP_SCHEDULE_Static);
----------------
Nit: Can this FIXME be removed?


================
Comment at: mlir/tools/mlir-tblgen/DirectiveCommonGen.cpp:73
 
-      const auto name = cval.getFormattedName();
+      const std::string name = cval.getFormattedName();
+      std::string enumValName(name.length(), ' ');
----------------
Nit: Is the const significant here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120825/new/

https://reviews.llvm.org/D120825