[PATCH] D113700: [AArch64] Improve costs for some conversions to fp16.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 03:12:59 PST 2022


dmgreen added a comment.

The new costs look good



================
Comment at: llvm/test/Analysis/CostModel/AArch64/cast.ll:445
 ; CHECK-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %r251 = sitofp <8 x i1> undef to <8 x half>
-; CHECK-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %r252 = uitofp <8 x i8> undef to <8 x half>
-; CHECK-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %r253 = sitofp <8 x i8> undef to <8 x half>
+; NOFP16-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %r252 = uitofp <8 x i8> undef to <8 x half>
+; NOFP16-NEXT:  Cost Model: Found an estimated cost of 1 for instruction: %r253 = sitofp <8 x i8> undef to <8 x half>
----------------
Use update_analyze_test_checks. You may find it is better to move the half checks to a separate function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113700/new/

https://reviews.llvm.org/D113700



More information about the llvm-commits mailing list