[PATCH] D121107: [DebugInfo][SROA] Correct debug info for global variables in case of SROA

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:416
+    // Ignore negative offset.
+    if (CurVarOffsetInBytes < 0)
+      continue;
----------------
this is new? should this be tested as well?


================
Comment at: llvm/test/DebugInfo/X86/global-sra-struct-fit-segment.ll:20-23
+; ModuleID = '/tmp/global-sra-struct-fit-segment.ll'
+source_filename = "/tmp/global-sra-struct-fit-segment.ll"
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
----------------
this could also be deleted I guess


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121107/new/

https://reviews.llvm.org/D121107