[PATCH] D121268: [AMDGPU] Control flow pseudos are not part of block prologue

[Carl Ritson via Phabricator via llvm-commits]

critson added a comment.

I need to rewrite the test.



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:7604
+    return false;
+  switch (MI.getOpcode()) {
+  case AMDGPU::COPY:
----------------
ruiling wrote:
> I think SI_IF_BREAK can be removed from the list as it does not modifies EXEC. SI_END_CF should be removed from the list, as SI_END_CF means the join point, we should treat it as block prologue. Other instructions should never be prologue instructions, so it is correct to list them here.
Agree, I think with your suggest this patch is correct.
Although it was not the root cause of the bug I am chasing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121268/new/

https://reviews.llvm.org/D121268