[PATCH] D120897: [flang] Remove 'using namespace mlir;` from header files

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 00:26:44 PST 2022


clementval accepted this revision.
clementval added a comment.

LGTM



================
Comment at: flang/lib/Lower/Bridge.cpp:42
 
+using namespace mlir;
+
----------------
awarzynski wrote:
> clementval wrote:
> > Wouldn't it make more sense to just get rid of it since we want fully qualified names? Same for other places.
> That would be a much more intrusive patch. I wanted to avoid that while the upstreaming is in progress. 
Ok makes sense and thanks to be thoughtful about the upstreaming. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120897/new/

https://reviews.llvm.org/D120897



More information about the llvm-commits mailing list