[PATCH] D117946: [JITLink][RISCV] Refactor range checking and alignment checking

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 23:36:06 PST 2022


StephenFan added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h:371
 ///   Local -- Visible only within the LinkGraph.
-enum class Scope : uint8_t {
-  Default,
-  Hidden,
-  Local
-};
+enum class Scope : uint8_t { Default, Hidden, Local };
 
----------------
fourdim wrote:
> StephenFan wrote:
> > Don't modify irrelevant parts
> I'm sorry but it is automatically modified by clang-format. Should I disable this?
I usually use `git clang-format` to clang-format the staged changes. This would not format irrelevant parts


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117946/new/

https://reviews.llvm.org/D117946



More information about the llvm-commits mailing list