[PATCH] D121005: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.



================
Comment at: llvm/unittests/ObjCopy/ObjCopyTest.cpp:24
 
-void copySimpleInMemoryFileImpl(
-    const char *YamlCreationString,
-    std::function<bool(const Binary &File)> IsValidFormat) {
+const char *YamlForSimpleFileCOFF = R"(
+--- !COFF
----------------
Simpler name: `SimpleFileCOFFYAML`. Similar for the others.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121005/new/

https://reviews.llvm.org/D121005