[PATCH] D121250: [DFSan] Remove trampolines to unblock opaque pointers.https://github.com/llvm/llvm -project/issues/54172

Andrew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 13:36:57 PST 2022


browneee added inline comments.


================
Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:2078
+  //
+  // TODO(browneee): Consider a builtin to improve maintainabliity.
+  // With a builtin, we would provide the argument labels via builtin,
----------------
I haven't done this now because this one function would currently be the only place that would use it.

The other code in dfsan_custom.cpp that have callbacks pass in data which is considered not tainted, so we can just zero it all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121250/new/

https://reviews.llvm.org/D121250



More information about the llvm-commits mailing list