[PATCH] D121243: [InstCombine] Preserve FMF in foldLogicOfFCmps.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 13:30:29 PST 2022


craig.topper added a comment.

In D121243#3368116 <https://reviews.llvm.org/D121243#3368116>, @lebedev.ri wrote:

> https://llvm.org/docs/LangRef.html#id306 says:
>
>> Any set of fast-math flags are legal on an fcmp instruction, but the only flags that have any effect on its semantics are those that allow assumptions to be made about the values of input arguments; namely nnan, ninf, and reassoc. See Fast-Math Flags for more information.
>
> So please add tests with `reassoc`?

Alive2 can't seem to verify the reassoc preservation. Is it better to drop everything but nnan and ninf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121243/new/

https://reviews.llvm.org/D121243



More information about the llvm-commits mailing list