[PATCH] D121229: [AMDGPU] Split FeatureAtomicFaddInsts feature. NFC.

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

Please check with Brian he does not use atomic-fadd-insts in the library.



================
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:2547
 
-let SubtargetPredicate = HasAtomicFaddInsts in {
-
----------------
Why is this predicate dropped?


================
Comment at: llvm/lib/Target/AMDGPU/FLATInstructions.td:1602
 
-let SubtargetPredicate = HasAtomicFaddInstsGFX90X in {
+let SubtargetPredicate = isGFX8GFX9NotGFX940 in {
+// These instructions are encoded differently on gfx90* and gfx940.
----------------
GFX8?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121229/new/

https://reviews.llvm.org/D121229