[PATCH] D121167: [NewPM] Actually recompute GlobalsAA before module optimization pipeline

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1169
   // memory operations.
-  MPM.addPass(RequireAnalysisPass<GlobalsAA, Module>());
+  MPM.addPass(RecomputeGlobalsAAPass());
 
----------------

Is there a drawback to just doing `MPM.addPass(InvalidateAnalysisPass<GlobalsAA>());` before re-requiring `GlobalsAA`? At least for the test case, it looks like this is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121167/new/

https://reviews.llvm.org/D121167