[PATCH] D121229: [AMDGPU] Split FeatureAtomicFaddInsts feature. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 09:47:32 PST 2022


foad created this revision.
foad added reviewers: rampitec, Joe_Nash.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
Herald added a project: All.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Split the feature into separate FeatureAtomicFaddNoRtnInsts and
FeatureAtomicFaddRtnInsts features. Previously isGFX90A was used as a
proxy for the latter.

The motivation for this is to avoid having to define more compound
predicates like HasAtomicFaddInstsGFX90X. Instead we can set the
SubtargetPredicate and OtherPredicates appropriately, and everything
just works.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121229

Files:
  llvm/lib/Target/AMDGPU/AMDGPU.td
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  llvm/lib/Target/AMDGPU/BUFInstructions.td
  llvm/lib/Target/AMDGPU/FLATInstructions.td
  llvm/lib/Target/AMDGPU/GCNSubtarget.h
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/global-atomics-fp-wrong-subtarget.ll
  llvm/test/CodeGen/AMDGPU/global-atomics-fp.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.atomic.fadd.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121229.413850.patch
Type: text/x-patch
Size: 13043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220308/326b83d0/attachment.bin>


More information about the llvm-commits mailing list