[PATCH] D120993: [PassManager] Add pretty stack entries before P->run() call.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:395
+};
+struct CrashingCGSCCPass : public PassInfoMixin<CrashingLoopPass> {
+  PreservedAnalyses run(LazyCallGraph::SCC &, CGSCCAnalysisManager &,
----------------
aeubanks wrote:
> `CrashingCGSCCPass`
Thanks, that should bet tied now.


================
Comment at: llvm/test/Other/crash-module.ll:7
+; CHECK:      Stack dump:
+; CHECK-NEXT: 0. Program arguments: {{.+}}opt -passes=crash-module
+; CHECK-NEXT: 1. Running pass 'CrashingModulePass' on module
----------------
aeubanks wrote:
> this is failing on windows, I don't think we need to be so strict on checking this line
Was the issue that part after `Program arguments:`? I dropped that from the checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120993/new/

https://reviews.llvm.org/D120993