[PATCH] D119762: AMDGPU: Set up User SGPRs for queue_ptr only when necessary

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:166-171
+unsigned getQueuePtrImplicitArgPosition() {
+  if (AmdhsaCodeObjectVersion == 5)
+    return 200;
+  llvm_unreachable("queue_ptr is supported only by code object version 5");
+  return 0;
+}
----------------
arsenm wrote:
> This isn't a scalable solution for all of the inputs. Should have an enum with offsets or something
Will do this in a following patch because the enum of the implicit kernel arguments will also be used there. Still thinking of the appropriate definition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119762/new/

https://reviews.llvm.org/D119762