[PATCH] D121217: InstCombine: Can't fold a phi arg load into the phi if the load is from a swifterror address

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 08:14:41 PST 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! This matches the spec in LangRef.

But in general, I'd expect this restriction not being enforced in many other places. Is there a verifier that rejects invalid uses of `swifterror`?



================
Comment at: llvm/test/Transforms/InstCombine/phi-equal-incoming-pointers.ll:620
+;
+
+
----------------
nit: remove empty lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121217/new/

https://reviews.llvm.org/D121217



More information about the llvm-commits mailing list