[PATCH] D121016: [PowerPC] Fix the none tail call in scalar MASS conversion

Tue Mar 8 08:09:13 PST 2022

jsji added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:17760
                                           SelectionDAG &DAG) const {
   const TargetLowering &TLI = DAG.getTargetLoweringInfo();
   TargetLowering::CallLoweringInfo CLI(DAG);
----------------
masoud.ataei wrote:
> jsji wrote:
> > What is the reason that we don't want to use `TLI.makeLibCall` here?
> At first, I thought this function will be way simpler than `TLI.makeLibCall` but now that they are too similar, I will try to call `makeLibCall` function. There are still some implementation details that needs to be take care of, like `RTLIB::Libcall` and `CallOptions`. 
> 
> Since I am fixing a bug here, I will commit this patch as is and will work on creating a new patch to use `TLI.makeLibCall`. 
Sounds good. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121016/new/

https://reviews.llvm.org/D121016