[PATCH] D120993: [PassManager] Add pretty stack entries before P->run() call.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 07:52:13 PST 2022


fhahn updated this revision to Diff 413809.
fhahn marked an inline comment as done.
fhahn added a comment.



In D120993#3361927 <https://reviews.llvm.org/D120993#3361927>, @aeubanks wrote:

> Definitely seems good.
> This  should be added for all adaptors (module->cgscc,module->function,cgscc->function,function->loop) and pass managers (loop/cgscc are implemented separately)
> PassManager.h/cpp, LoopPassManager.h/cpp, CGSCCPassManager.h/cpp
>
> Could be tested with the crash pass that was supposed to be landed in https://reviews.llvm.org/D86657, which needs to be relanded

I added the missing implementations and added crashing passes for all of them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120993/new/

https://reviews.llvm.org/D120993

Files:
  llvm/include/llvm/IR/PassManager.h
  llvm/include/llvm/Transforms/Scalar/LoopPassManager.h
  llvm/lib/Analysis/CGSCCPassManager.cpp
  llvm/lib/IR/PassManager.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/Scalar/LoopPassManager.cpp
  llvm/test/Other/crash-cgscc.ll
  llvm/test/Other/crash-function.ll
  llvm/test/Other/crash-loop.ll
  llvm/test/Other/crash-module.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120993.413809.patch
Type: text/x-patch
Size: 10554 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220308/a3215e63/attachment.bin>


More information about the llvm-commits mailing list