[PATCH] D120481: [AArch64] Try to re-use extended operand for SETCC with v16i8 operands.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 413756.
fhahn marked 2 inline comments as done.
fhahn added a comment.

Rebased on top of new test case, removed whitespace change.

In D120481#3353908 <https://reviews.llvm.org/D120481#3353908>, @dmgreen wrote:

> Sorry for the delay. It took a while to find the time to figure out what was wrong, but it turned out that was in the other patch.
>
> The change sounds OK to me, although it might be useful to generalize it to handle more types. This seems like it is useful in a few more cases: https://godbolt.org/z/fo8MMrqrE. I'm not sure if this generalises to not just select uses.

Thanks for taking a look! Agreed that it will be helpful for a couple of other type combinations. But maybe the generalization should be done as follow-ups?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120481/new/

https://reviews.llvm.org/D120481

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/vselect-ext.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120481.413756.patch
Type: text/x-patch
Size: 5603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220308/7fe12ad0/attachment.bin>