[PATCH] D121114: [VP] Add widening for VP_STRIDED_LOAD and VP_STRIDED_STORE

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 01:43:06 PST 2022


frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4452
+  assert(Mask.getValueType().getVectorElementCount() ==
+             TLI.getTypeToTransformTo(*DAG.getContext(), Mask.getValueType())
+                 .getVectorElementCount() &&
----------------
This may well be copy/pasted from elsewhere (and possibly something I introduced...), but this assert looks fishy to me. Aren't we wanting to check that the widened `Mask` is the same length as the widened result type, like `WidenVT` below? This assert looks trivially true as it stands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121114/new/

https://reviews.llvm.org/D121114



More information about the llvm-commits mailing list