[PATCH] D121183: [RISCV] Generate correct ELF EFlags when .ll file has target-abi attribute

Zakk Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 22:48:31 PST 2022


khchen added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/module-target-abi2.ll:16
 ; DEFAULT-NEXT: fcvt.s.w fa0, a0
 ; DEFAULT-NEXT: ret
 ; RV32IF-ILP32F: # %bb.0:
----------------
The elf attribute becomes correct, but I think the assembly is still incorrect?
LLVM can not read the -target-abi from IR and overwrite the MCTargetOptions.ABIName,
It's why https://reviews.llvm.org/D102582 would like to report an error if users give the mismatch -target-abi comparing to IR's.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121183/new/

https://reviews.llvm.org/D121183



More information about the llvm-commits mailing list