[PATCH] D120230: [SelectOpti][1/4] Setup new select-optimize pass

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CodeGenPassBuilder.h:673
+  // Convert conditional moves to conditional jumps when profitable.
+  if (getOptLevel() != CodeGenOpt::None && !Opt.DisableSelectOptimize)
+    addPass(SelectOptimizePass());
----------------
Do we need a canonicalization phase before this to convert jumps to select when possible?


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:933
+  // Convert conditional moves to conditional jumps when profitable.
+  if (getOptLevel() != CodeGenOpt::None && !DisableSelectOptimize)
+    addPass(createSelectOptimizePass());
----------------
Not suitable when size optimization is on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120230/new/

https://reviews.llvm.org/D120230