[PATCH] D120137: [lld-macho] Deduplicate CFStrings during ICF

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/ICF.cpp:119
+      else if (isa<Undefined>(sa)) // ICF runs before Undefineds are reported.
+        return false;
+      assert(isa<Defined>(sa));
----------------
Roger wrote:
> For the `Undefined` case, it looks like we're making a functional change from returning `sa == sb` to always returning false. Was the previous behavior a bug? Is this `Undefined` symbol a symbol that needs to be linked to a definition in another source file?
oops, no, the previous behavior was intended. Let me fix this and add a test so we don't regress


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120137/new/

https://reviews.llvm.org/D120137