[PATCH] D120000: [1/3] TLS loads opimization (hoist)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/TLSVariableHoist.cpp:239
+  tlshoist::TLSCandidate &Cand = TLSCandMap[GV];
+  if (!DT)
+    return findInsertPosInEntry(Fn, Cand);
----------------
xiangzhangllvm wrote:
> craig.topper wrote:
> > Why would DT be null? The pass has DominatorTree as a requirement.
> I am not sure if its requirement will must successful build/generate a DominatorTree.
> Or here let me change to assert (DT) ?
You can use assert(DT)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000