[PATCH] D121167: [NewPM] Actually recompute GlobalsAA before module optimization pipeline

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
Herald added subscribers: ormris, wenlei, steven_wu, hiraditya.
Herald added a reviewer: ctetreau.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

RequireAnalysis<GlobalsAA> doesn't actually recompute GlobalsAA.
GlobalsAA isn't invalidated (unless specifically invalidated) because
it's self-updating via ValueHandles, but can be imprecise during the
self-updates.

Rather than invalidating GlobalsAA, which would invalidate AAManager and
any analyses that use AAManager, create a new pass that recomputes
GlobalsAA.

Fixes #53131.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121167

Files:
  llvm/include/llvm/Analysis/GlobalsModRef.h
  llvm/lib/Analysis/GlobalsModRef.cpp
  llvm/lib/Passes/PassBuilderPipelines.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/test/Other/new-pm-defaults.ll
  llvm/test/Other/new-pm-thinlto-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Transforms/PhaseOrdering/recompute-globalsaa.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121167.413643.patch
Type: text/x-patch
Size: 7790 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220307/3f7a9581/attachment.bin>