[PATCH] D121157: [AMDGPU] always use underlying object in the pointsToConstantMemory

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 15:11:13 PST 2022


arsenm added a comment.

In D121157#3365640 <https://reviews.llvm.org/D121157#3365640>, @rampitec wrote:

> In D121157#3365638 <https://reviews.llvm.org/D121157#3365638>, @rampitec wrote:
>
>> In D121157#3365629 <https://reviews.llvm.org/D121157#3365629>, @rampitec wrote:
>>
>>> 
>>
>> Sorry, it is actually LoadStoreVectorizer.cpp.
>
> @arsenm believe it or not, this is actually your commit 42ad17059acc677b5d759cb02bd008e73ffacd4b from 2016! This:
>
>   +    if (LoadTy->isPtrOrPtrVectorTy()) {
>   +      LoadTy = Type::getIntNTy(F.getParent()->getContext(),
>   +                               DL.getTypeSizeInBits(LoadTy));
>   +      break;
>   +    }

Ugh, there isn't another way to do merge a pointer with a non pointer load


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121157/new/

https://reviews.llvm.org/D121157



More information about the llvm-commits mailing list