[PATCH] D121157: [AMDGPU] always use underlying object in the pointsToConstantMemory

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D121157#3365553 <https://reviews.llvm.org/D121157#3365553>, @rampitec wrote:

> In D121157#3365531 <https://reviews.llvm.org/D121157#3365531>, @arsenm wrote:
>
>> In D121157#3365530 <https://reviews.llvm.org/D121157#3365530>, @rampitec wrote:
>>
>>> @arsenm Do you think it makes sense to check if getUnderlyingObject actually brought one of: Argument, GlobalValue, or ConstantAggregate?
>>
>> I would assume the base implementation handles that, but we're already checking for GlobalValue
>
> isConstant is not the same as constant address space though. Then for argument a qualifier const also does not replace constant.

The point of the method is to return if the memory is modified, not if it's constant address space


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121157/new/

https://reviews.llvm.org/D121157