[PATCH] D120861: [XCOFF][1/3] support fileHeader and sectionHeaders in 64-bit XCOFF.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-available-externally-linkage.ll:14
 
-; RUN: not --crash llc -verify-machineinstrs -mtriple powerpc64-ibm-aix-xcoff \
-; RUN:     -mcpu=pwr4 -mattr=-altivec -filetype=obj -o %t.o 2>&1 < %s | \
-; RUN:   FileCheck --check-prefix=XCOFF64 %s
-; XCOFF64: LLVM ERROR: 64-bit XCOFF object files are not supported yet.
+;; FIXME: currently only fileHeader and sectionHeaders are supported in XCOFF64.
 
----------------
DiggerLin wrote:
>  I do not think there is anything to remind us to delete the  ";; FIXME:..." in later patch and and add 64bit object file test. 
> maybe we can add writeSymbolEntry for 64 bit in the patch  , and using 
> 
> ```
>  if (TargetObjectWriter->is64Bit())
>     report_fatal_error("64-bit XCOFF object files are not supported yet.");
> ```
> in the function.
>  
> and then you do not need to modify all the test cases.
please ignore above comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120861/new/

https://reviews.llvm.org/D120861