[PATCH] D121157: [AMDGPU] always use underlying object in the pointsToConstantMemory
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 7 13:50:50 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp:135
const Value *Base = getUnderlyingObject(Loc.Ptr);
- AS = Base->getType()->getPointerAddressSpace();
if (AS == AMDGPUAS::CONSTANT_ADDRESS ||
----------------
I think using the getUnderlyingObject result has the same fundamental problem. It looks as far back as it can, but doesn't necessarily find the object definition. e.g. you could hit a call that returns the pointer which casted the pointer inside it
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121157/new/
https://reviews.llvm.org/D121157
More information about the llvm-commits
mailing list