[PATCH] D119762: AMDGPU: Set up User SGPRs for queue_ptr only when necessary

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 13:47:02 PST 2022


cfang added a reviewer: scott.linder.
cfang marked an inline comment as done.
cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:55
+                    bool HasApertureRegs, bool SupportsGetDoorBellID ) {
+  unsigned CodeObjectVersion = AMDGPU::getAmdhsaCodeObjectVersion();
   switch (ID) {
----------------
arsenm wrote:
> This really ought to be something read from the IR
As discussed in another review (https://reviews.llvm.org/D119027 
"IIUC the global opt var is the best we have right now, and any improvement to that situation is orthogonal to this change. I would vote that this not block the patch under review!"), we are using the global opt var for this change. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119762/new/

https://reviews.llvm.org/D119762



More information about the llvm-commits mailing list