[PATCH] D121016: [PowerPC] Fix the none tail call in scalar MASS conversion

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 13:20:50 PST 2022


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM other than the test cases that need to be improved.



================
Comment at: llvm/test/CodeGen/PowerPC/lower-intrinsics-afn-mass_notail.ll:6
+; CHECK-LABEL: cos_f64
+; CHECK: __xl_cos
+bb:
----------------
This check is not adequate. You have added code to ensure that the function isn't tail called when it isn't in a tail call position, yet your test doesn't check anything along those lines.
It is probably best to simply use `update_llc_test_checks.py` to produce the checks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121016/new/

https://reviews.llvm.org/D121016



More information about the llvm-commits mailing list