[PATCH] D119594: [sancov] Don't instrument calls to bitcast funcs: they're not indirect.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 12:44:47 PST 2022


ab added a comment.

Thanks!



================
Comment at: llvm/test/Instrumentation/SanitizerCoverage/trace-pc-guard.ll:66
+; CHECK-NOT:     call void @__sanitizer_cov_trace_pc_indir
+; CHECK:         call void bitcast (i32 ()* @direct_callee to void ()*)()
+; CHECK:         ret void
----------------
MaskRay wrote:
> Delete `-NOT`. Consecutive `-NEXT` patterns can ensure there is only one `__sanitizer_cov_trace_*` call.
Sure; replaced with `-NEXT` of `trace_pc_guard` call


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119594/new/

https://reviews.llvm.org/D119594



More information about the llvm-commits mailing list