[PATCH] D120650: [ELF] Don't use multiple inheritance for OutputSection. NFC

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 09:23:00 PST 2022


ikudrin accepted this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.

LGTM



================
Comment at: lld/ELF/Writer.cpp:1171
   for (; i != e; ++i) {
-    auto *curSec = dyn_cast<OutputSection>(*i);
-    if (!curSec || !curSec->hasInputSections)
+    auto *curSec = dyn_cast<OutputDesc>(*i);
+    if (!curSec || !curSec->osec.hasInputSections)
----------------
`curSec` -> `curSecDesc` maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120650/new/

https://reviews.llvm.org/D120650



More information about the llvm-commits mailing list