[PATCH] D121128: [regalloc] Remove -consider-local-interval-cost

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin created this revision.
mtrofin added reviewers: qcolombet, nikic, aditya_nandakumar, dmgreen, MatzeB.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
mtrofin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Discussed extensively on D98232 <https://reviews.llvm.org/D98232>. The functionality introduced in D35816 <https://reviews.llvm.org/D35816>
never worked correctly. In D98232 <https://reviews.llvm.org/D98232>, it was fixed, but, as it was
introducing a large compile-time regression, and the value of the
original patch was called into doubt, we disabled it by default
everywhere. A year later, it appears that caused no grief, so it seems
safe to remove the disabled code.

This should be accompanied by re-opening bug 26810.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121128

Files:
  llvm/include/llvm/CodeGen/TargetSubtargetInfo.h
  llvm/lib/CodeGen/RegAllocGreedy.cpp
  llvm/lib/CodeGen/RegAllocGreedy.h
  llvm/lib/CodeGen/TargetSubtargetInfo.cpp
  llvm/lib/Target/AArch64/AArch64Subtarget.h
  llvm/lib/Target/X86/X86Subtarget.h
  llvm/test/CodeGen/AArch64/ragreedy-local-interval-cost.ll
  llvm/test/CodeGen/X86/bug26810.ll
  llvm/test/CodeGen/X86/greedy_regalloc_bad_eviction_sequence.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121128.413496.patch
Type: text/x-patch
Size: 51109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220307/1656926b/attachment-0001.bin>