[PATCH] D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 07:14:49 PST 2022


tstellar added a comment.

I think we need to land this patch.  It's fixing a major regression from the new pass manager which is blocking some users from even upgrading to LLVM 13.  I understand that there are concerns that it may regress performance in some cases, but I think that fixing the regression is more important especially since we have not actually identified any real world cases that would regress.  It also sounds like there is at least one downsteam user working around this regression in their own tree, and given the impact of the problem, we would also have to fix this downstream in Fedora as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120584/new/

https://reviews.llvm.org/D120584



More information about the llvm-commits mailing list