[PATCH] D121005: [objcopy][NFC] Move NameOrPattern::create() into CommonConfig.h

Mon Mar 7 04:48:53 PST 2022

avl added inline comments.

================
Comment at: llvm/unittests/ObjCopy/ObjCopyTest.cpp:439
+      R"(
+--- !COFF
+header:
----------------
jhenderson wrote:
> If this YAML is identical to other cases, pull it into a shared constant somewhere.
I suggest to not use shared constants here. These are different places(even if yaml descriptions look similar). Changing in one place should not necessarily be reflected in others. Also it is more convenient to see them inplace rather then moved to constant definition.

Though if you still think we need shared constants here - will update the patch accordingly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121005/new/

https://reviews.llvm.org/D121005