[PATCH] D120927: [llvm] remove empty __LLVM segment in llvm-bitcode-strip

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one change.

By the way, if you haven't already, you've probably done enough to request commit access.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/bitcode-strip-remove.test:14
+# CHECK-NEXT: Name: __DATA
+# CHECK-NOT:  Name: __LLVM
 
----------------
No need for this line: 1) the `--implicit-check-not` covers it. 2) This won't catch `__LLVM` appearing before or between the other segments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120927/new/

https://reviews.llvm.org/D120927