[PATCH] D120887: The [2/2] Fix mangle problem when variable used in inline asm （non-rip for ARR[BaseReg+IndexReg+..]）

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:6204
+      if (isSpecialIntelExprAppend(AsmStrRewrites, it))
+        OS << "${" << InputIdx++ << ":P}";
+      else
----------------
xiangzhangllvm wrote:
> MODIFIER :P will disable ASMPrinter print PC related style for a Global Address.
Let me take a look if here isSpecialIntelExprAppend can be checked earlier and cover case "[ARR + ecx + eax * 4]"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120887/new/

https://reviews.llvm.org/D120887